KAFKA-19176: Update Transactional producer to translate retriable into abortable exceptions #19522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
k-raina
changed the title
jolshan
reviewed
Apr 24, 2025
| if (error == null) | ||
| throw new IllegalArgumentException("Cannot transition to " + target + " with a null exception"); | ||
|
|
||
| if (error instanceof RetriableException) { |
Member
There was a problem hiding this comment.
Can we leave a comment that RetriableExceptions from the Sender thread should be translated to abortable?
jolshan
reviewed
Apr 24, 2025
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@jolshan Thanks for review |
jolshan
reviewed
Jun 3, 2025
| // RetriableExceptions from the Sender thread are converted to Abortable errors | ||
| // because they indicate that the transaction cannot be completed after all retry attempts. | ||
| // This conversion ensures the application layer treats these errors as abortable, | ||
| // preventing duplicate message delivery. |
Member
There was a problem hiding this comment.
maybe not a change we need now, but it isn't totally clear from the method name that this should only be called from the sender thread. Maybe we should refactor this in the future.
Contributor
Author
There was a problem hiding this comment.
Agree.. Got me confused too.
Thanks for review
k-raina
added a commit
to k-raina/kafka
that referenced
this pull request
Jun 17, 2025
…o abortable exceptions (apache#19522) ### Problem - Currently, when a transactional producer encounters retriable errors (like `COORDINATOR_LOAD_IN_PROGRESS`) and exhausts all retries, finally returns retriable error to Application Layer. - Application reties can cause duplicate records. As a fix we are transitioning all retriable errors as Abortable Error in transaction producer path. - Additionally added InvalidTxnStateException as part of https://issues.apache.org/jira/browse/KAFKA-19177 ### Solution - Modified the TransactionManager to automatically transition retriable errors to abortable errors after all retries are exhausted. This ensures that applications can abort transaction when they encounter `TransactionAbortableException` - `RefreshRetriableException` like `CoordinatorNotAvailableException` will be refreshed internally [[code](https://github.com/k-raina/kafka/blob/6c26595ce3d1608ae98ad4958b2ff8776a025fc3/clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java#L1702-L1705)] till reties are expired, then it will be treated as retriable errors and translated to `TransactionAbortableException` - Similarly for InvalidTxnStateException ### Testing Added test `testSenderShouldTransitionToAbortableAfterRetriesExhausted` to verify in sender thread: - Retriable errors are properly converted to abortable state after retries - Transaction state transitions correctly and subsequent operations fail appropriately with TransactionAbortableException Reviewers: Justine Olshan <jolshan@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when a transactional producer encounters retriable errors
(like
COORDINATOR_LOAD_IN_PROGRESS) and exhausts all retries, finallyreturns retriable error to Application Layer.
Application reties can cause duplicate records. As a fix we are
transitioning all retriable errors as Abortable Error in transaction
producer path.
Additionally added InvalidTxnStateException as part of
https://issues.apache.org/jira/browse/KAFKA-19177
Solution
Modified the TransactionManager to automatically transition retriable
errors to abortable errors after all retries are exhausted. This ensures
that applications can abort transaction when they encounter
TransactionAbortableExceptionRefreshRetriableExceptionlikeCoordinatorNotAvailableExceptionwill be refreshed internally
[code]
till reties are expired, then it will be treated as retriable errors and
translated to
TransactionAbortableExceptionSimilarly for InvalidTxnStateException
Testing
Added test
testSenderShouldTransitionToAbortableAfterRetriesExhaustedto verify in sender thread:
retries
appropriately with TransactionAbortableException
Reviewers: Justine Olshan jolshan@confluent.io