KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module #19528

yunchipang · 2025-04-21T15:12:47Z

rewrite MetricsDuringTopicCreationDeletionTest to ClusterTest infra
and move it to clients-integration-tests module.

Reviewers: PoAn Yang payang@apache.org, Ken Huang s7133700@gmail.com, Jhen-Yung Hsu jhenyunghsu@gmail.com, Chia-Ping Tsai chia7712@gmail.com

…erTest

…tial.task.delay.ms cluster config prop. test passed

chia7712

@yunchipang thanks for this patch. could you please run ./gradlew spotlessApply to format the imports. Additionally, please add <allow pkg="com.yammer.metrics.core" /> to https://github.com/apache/kafka/blob/trunk/checkstyle/import-control-clients-integration-tests.xml.

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java

FrankYang0529

Thanks for the PR. Leave some comments.

FrankYang0529 · 2025-04-26T07:31:38Z

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java

+            initialOfflinePartitionsCount = getGauge("OfflinePartitionsCount").value();
+            initialPreferredReplicaImbalanceCount = getGauge("PreferredReplicaImbalanceCount").value();
+            initialUnderReplicatedPartitionCount = getGauge("UnderReplicatedPartitions").value();


Will these initial variables get other value after setUp function? If not, we can remove this block and set them as final value.

private final int initialOfflinePartitionsCount = 0; private final int initialPreferredReplicaImbalanceCount = 0; private final int initialUnderReplicatedPartitionCount = 0;

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java

test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java

Yunyung

Thanks for the PR. I left some comments and please update the PR title client->clients.

build.gradle

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java

m1a2st

Thanks @yunchipang for this patch, a little comments

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java

…egration-tests module (apache#19528) rewrite `MetricsDuringTopicCreationDeletionTest` to `ClusterTest` infra and move it to clients-integration-tests module. Reviewers: PoAn Yang <payang@apache.org>, Ken Huang <s7133700@gmail.com>, Jhen-Yung Hsu <jhenyunghsu@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>

(wip) rewrite MetricsDuringTopicCreationDeletionTest.scala with Clust…

9ad1754

…erTest

github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) labels Apr 21, 2025

yunchipang added 3 commits April 22, 2025 11:51

(wip) change metrics checking logic; add async topic deletion config

0ef952b

cleanup commented code

bb5df87

migrate scala-based test to CluterTest, set replica=1 and add log.ini…

3ac6906

…tial.task.delay.ms cluster config prop. test passed

yunchipang changed the title ~~[WIP] KAFKA-19170: migrate MetricsDuringTopicCreationDeletionTest~~ [WIP] KAFKA-19170: Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module Apr 23, 2025

yunchipang added 2 commits April 24, 2025 18:49

convert scala-based test inplace to java

5791062

moved to clients-integration-tests, checkstyleTest not passed

9932251

github-actions bot added build Gradle build or GitHub Actions clients labels Apr 25, 2025

chia7712 reviewed Apr 25, 2025

View reviewed changes

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java Outdated Show resolved Hide resolved

yunchipang added 2 commits April 25, 2025 14:13

run spotlessApply to format imports; allow com.yammer.metrics.core

928f05d

replace old-school thread with Closeable

b39870d

yunchipang commented Apr 25, 2025

View reviewed changes

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java Outdated Show resolved Hide resolved

yunchipang marked this pull request as ready for review April 25, 2025 21:33

FrankYang0529 added the ci-approved label Apr 26, 2025

github-actions bot removed the triage PRs from the community label Apr 26, 2025

FrankYang0529 reviewed Apr 26, 2025

View reviewed changes

chia7712 changed the title ~~[WIP] KAFKA-19170: Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module~~ KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module Apr 26, 2025

chia7712 reviewed Apr 26, 2025

View reviewed changes

yunchipang added 4 commits April 28, 2025 16:18

remove forEach broker block

ad861c8

use List.of() in deleteTopics instead of Collections.singletonList()

fee1bcd

throw exception instead of catching it in setUp()

22984dc

replace int[] with just int

6a5ff36

chia7712 reviewed Apr 29, 2025

View reviewed changes

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java Outdated Show resolved Hide resolved

yunchipang added 3 commits April 29, 2025 10:56

merge closed with running (same purpose)

4018bf4

move initial metrics fetch to test-level

8d303bf

move runThread to test-level

3cc96ae

extract createAndDeleteTopics; add sleep in thread

5ecd2a1

yunchipang requested a review from chia7712 April 30, 2025 21:37

Yunyung reviewed May 4, 2025

View reviewed changes

yunchipang added 4 commits May 4, 2025 17:21

replace 'com.yammer.metrics:metrics-core:2.2.0' with libs.metrics

ddb406e

use only one tab

6676a48

remove 'Jenkins' from comment

5aea56a

revert indentation; remove redundant running=True

967ceb5

m1a2st reviewed May 5, 2025

View reviewed changes

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java Outdated Show resolved Hide resolved

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java Outdated Show resolved Hide resolved

remove printStackprintStackTrace; make REPLICATION_FACTOR short

df725ab

chia7712 reviewed May 5, 2025

View reviewed changes

small fixes

81fce69

chia7712 reviewed May 5, 2025

View reviewed changes

...ion-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java Show resolved Hide resolved

add brokers=1 to config

ddbe4c7

yunchipang requested review from FrankYang0529, Yunyung, chia7712 and m1a2st May 6, 2025 00:17

chia7712 approved these changes May 6, 2025

View reviewed changes

chia7712 merged commit 4e77466 into apache:trunk May 6, 2025
20 checks passed

yunchipang deleted the KAFKA-19170-migrate-MetricsDuringTopicCreationDeletionTest-to-java branch May 6, 2025 16:19

KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module #19528

KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module #19528

Uh oh!

Conversation

yunchipang commented Apr 21, 2025 • edited by chia7712 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chia7712 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

FrankYang0529 left a comment

Choose a reason for hiding this comment

Uh oh!

FrankYang0529 Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yunyung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

m1a2st left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yunchipang commented Apr 21, 2025 •

edited by chia7712

Loading

FrankYang0529 Apr 26, 2025 •

edited

Loading