MINOR : Handle error for client telemetry push #19881

k-raina · 2025-06-02T15:30:39Z

Update catch to handle compression errors

Before :

After

Sent message: KR Message 376
[kafka-producer-network-thread | kr-kafka-producer] INFO
org.apache.kafka.common.telemetry.internals.ClientTelemetryReporter -
KR: Failed to compress telemetry payload for compression: zstd, sending
uncompressed data
Sent message: KR Message 377

bbejeck

LGTM - but I'll defer to @apoorvmittal10 for the final say

chia7712 · 2025-06-02T18:17:14Z

@k-raina thanks for this contribution.

kafka/server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java

Line 219 in 78ea878

} catch (Exception exception) {

has analogous issue as NoClassDefFoundError is not caught correctly. Could you please fix it as well?

apoorvmittal10

Thanks for the PR, 1 minor query.

apoorvmittal10 · 2025-06-03T08:52:16Z

clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java

+            } catch (Throwable e) {
                log.info("Failed to compress telemetry payload for compression: {}, sending uncompressed data", compressionType);


For log.info("Failed to compress telemetry payload for...., should it be in debug mode i.e. silent exception. Or we should still log it in INFO mode so application is aware of? What others think @AndrewJSchofield @bbejeck @chia7712 @k-raina?

agreed. Using info may caused the log to be flooded with messages. If that is acceptable exception, then using debug mode should be fine.

Updated to debug logs 3ea7dbb

apoorvmittal10

Approving as we should have this fix in 4.1.

ijuma · 2025-07-10T15:23:00Z

clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java

                compressedPayload = ClientTelemetryUtils.compress(payload, compressionType);
-            } catch (IOException e) {
-                log.info("Failed to compress telemetry payload for compression: {}, sending uncompressed data", compressionType);
+            } catch (Throwable e) {


Catching Throwable like this isn't safe. Can we be more specific about the exception?

Did you mean specify the accurate exception, like IOException | NoClassDefFoundError, instead of Exception?

Catching Throwable like this isn't safe.

Could you share the details of your concern with me?

@ijuma Raised PR #20144

Could you share the details of your concern with me?

I see java docs guideline "An Error is a subclass of Throwable that indicates serious problems that a reasonable application should not try to catch"

Catching Throwable would catch things like OutOfMemoryException and various other exceptions that indicate the JVM should exit.

Update catch to handle compression errors Before : ![image](https://github.com/user-attachments/assets/c5ca121e-ba0c-4664-91f1-20b54abf67cc) After ``` Sent message: KR Message 376 [kafka-producer-network-thread | kr-kafka-producer] INFO org.apache.kafka.common.telemetry.internals.ClientTelemetryReporter - KR: Failed to compress telemetry payload for compression: zstd, sending uncompressed data Sent message: KR Message 377 ``` Reviewers: Apoorv Mittal <apoorvmittal10@gmail.com>, Bill Bejeck <bbejeck@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>

…20176) Update catch to handle compression errors Before : ![image](https://github.com/user-attachments/assets/c5ca121e-ba0c-4664-91f1-20b54abf67cc) After ``` Sent message: KR Message 376 [kafka-producer-network-thread | kr-kafka-producer] INFO org.apache.kafka.common.telemetry.internals.ClientTelemetryReporter - KR: Failed to compress telemetry payload for compression: zstd, sending uncompressed data Sent message: KR Message 377 ``` Reviewers: Apoorv Mittal <apoorvmittal10@gmail.com>, Bill Bejeck <bbejeck@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>

…20179) Update catch to handle compression errors Before : ![image](https://github.com/user-attachments/assets/c5ca121e-ba0c-4664-91f1-20b54abf67cc) After ``` Sent message: KR Message 376 [kafka-producer-network-thread | kr-kafka-producer] INFO org.apache.kafka.common.telemetry.internals.ClientTelemetryReporter - KR: Failed to compress telemetry payload for compression: zstd, sending uncompressed data Sent message: KR Message 377 ``` Reviewers: Apoorv Mittal <apoorvmittal10@gmail.com>, Bill Bejeck <bbejeck@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>

Update catch to handle compression errors Before : ![image](https://github.com/user-attachments/assets/c5ca121e-ba0c-4664-91f1-20b54abf67cc) After ``` Sent message: KR Message 376 [kafka-producer-network-thread | kr-kafka-producer] INFO org.apache.kafka.common.telemetry.internals.ClientTelemetryReporter - KR: Failed to compress telemetry payload for compression: zstd, sending uncompressed data Sent message: KR Message 377 ``` Reviewers: Apoorv Mittal <apoorvmittal10@gmail.com>, Bill Bejeck <bbejeck@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>

Handle error for client telemetry push

6d06557

github-actions bot added triage PRs from the community clients small Small PRs labels Jun 2, 2025

AndrewJSchofield requested a review from apoorvmittal10 June 2, 2025 16:18

AndrewJSchofield added ci-approved and removed triage PRs from the community labels Jun 2, 2025

Run spotless

a39ff0e

bbejeck approved these changes Jun 2, 2025

View reviewed changes

Address feedbacks

329cdce

github-actions bot added the core Kafka Broker label Jun 3, 2025

apoorvmittal10 reviewed Jun 3, 2025

View reviewed changes

apoorvmittal10 approved these changes Jun 3, 2025

View reviewed changes

Address feedbacks

3ea7dbb

apoorvmittal10 merged commit 82ea9d0 into apache:trunk Jun 3, 2025
20 checks passed

ijuma reviewed Jul 10, 2025

View reviewed changes

		} catch (Throwable e) {
		log.info("Failed to compress telemetry payload for compression: {}, sending uncompressed data", compressionType);

MINOR : Handle error for client telemetry push #19881

MINOR : Handle error for client telemetry push #19881

Conversation

k-raina commented Jun 2, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bbejeck left a comment

Choose a reason for hiding this comment

Uh oh!

chia7712 commented Jun 2, 2025

Uh oh!

apoorvmittal10 left a comment

Choose a reason for hiding this comment

Uh oh!

apoorvmittal10 Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

chia7712 Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

k-raina Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

apoorvmittal10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ijuma Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

chia7712 Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

k-raina Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

k-raina Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ijuma Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

k-raina commented Jun 2, 2025 •

edited by github-actions bot

Loading

k-raina Jul 10, 2025 •

edited

Loading