KAFKA-19447: Replace PartitionState with PartitionRegistration in makeFollower/makeLeader #20335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingyen066
changed the title
chia7712
reviewed
Aug 11, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@mingyen066 thanks for this cleanup. I have a couple of comments.
|
|
||
| // Constants defined for readability | ||
| private val zkVersion = 0 | ||
| private val partitionEpoch = 0 |
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/fetcher/ReplicaFetcherThreadBenchmark.java
Outdated
Show resolved
Hide resolved
TaiJuWu
reviewed
Aug 11, 2025
TaiJuWu
reviewed
Aug 11, 2025
core/src/test/scala/unit/kafka/cluster/AssignmentStateTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/cluster/AssignmentStateTest.scala
Outdated
Show resolved
Hide resolved
m1a2st
reviewed
Aug 11, 2025
Collaborator
m1a2st
left a comment
m1a2st
left a comment
There was a problem hiding this comment.
Thanks for this patch, some comments
core/src/test/scala/unit/kafka/cluster/AssignmentStateTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/cluster/AbstractPartitionTest.scala
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Aug 13, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@mingyen066 thanks for updates.
core/src/test/scala/unit/kafka/cluster/AssignmentStateTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/cluster/AssignmentStateTest.scala
Outdated
Show resolved
Hide resolved
…ionState-in-makeFollower/makeLeader
…ionState-in-makeFollower/makeLeader
chia7712
approved these changes
Aug 17, 2025
chia7712
approved these changes
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to
KAFKA-18486
makeFollower/makeLeader
Reviewers: TaiJuWu tjwu1217@gmail.com, Ken Huang s7133700@gmail.com,
Chia-Ping Tsai chia7712@gmail.com