KAFKA-19384: The passing of BrokerRegistrationRequestTest is a false positive #20338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
apalan60
commented
Aug 11, 2025
Comment on lines
155
to
163
| // No features (MV) sent with registration, controller can't verify | ||
| assertEquals( | ||
| Errors.BROKER_ID_NOT_REGISTERED, | ||
| registerBroker(channelManager, clusterId, 100, Some(1), None)) | ||
| Errors.INVALID_REGISTRATION, | ||
| registerBroker(channelManager, clusterId, 100, None, None)) | ||
|
|
||
| // Given MV is too high for controller to support | ||
| assertEquals( | ||
| Errors.BROKER_ID_NOT_REGISTERED, | ||
| registerBroker(channelManager, clusterId, 100, Some(1), Some((MetadataVersion.IBP_3_4_IV0.featureLevel, MetadataVersion.IBP_3_4_IV0.featureLevel)))) | ||
| Errors.UNSUPPORTED_VERSION, | ||
| registerBroker(channelManager, clusterId, 100, None, Some((MetadataVersion.IBP_3_4_IV0.featureLevel, MetadataVersion.IBP_3_4_IV0.featureLevel)))) |
Contributor
Author
There was a problem hiding this comment.
Previously, passing Some(1) as the zkEpoch parameter caused zkEpoch.isDefined to always be true, which led to a BrokerIdNotRegisteredException being thrown.
As a result, the intended test scenario was never actually tested.
chia7712
reviewed
Aug 14, 2025
core/src/test/java/kafka/server/BrokerRegistrationRequestTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/server/BrokerRegistrationRequestTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/server/BrokerRegistrationRequestTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@chia7712 |
chia7712
reviewed
Aug 15, 2025
server/src/test/java/org/apache/kafka/server/BrokerRegistrationRequestTest.java
Show resolved
Hide resolved
chia7712
reviewed
Aug 15, 2025
| return new NodeToControllerChannelManagerImpl( | ||
| new TestControllerNodeProvider(controllerSocketServer, clusterInstance), | ||
| Time.SYSTEM, | ||
| new Metrics(), |
Member
There was a problem hiding this comment.
Could you please close the metrics manually? NodeToControllerChannelManagerImpl does not handle it.
Contributor
Author
|
@chia7712 |
Contributor
Author
|
Seems the refactored test is causing a thread leak. I’m looking into a fix. |
…gistrationRequestTest to avoid thread leaks
chia7712
reviewed
Aug 16, 2025
| return Errors.forCode(resp.data().errorCode()); | ||
| } | ||
|
|
||
| record FeatureLevel(short min, short max) { } |
Member
There was a problem hiding this comment.
this could be replaced by BrokerRegistrationRequestData.Feature, shouldn't it?
Contributor
Author
There was a problem hiding this comment.
Addressed this, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a false positive in
BrokerRegistrationRequestTestcaused byisMigratingZkBroker, and migrates the test from Scala to Java.Reviewers: Chia-Ping Tsai chia7712@gmail.com