MINOR: Remove the MetaLogShim namings #20357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Aug 15, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@mapan1984 Thanks for this patch. That's something we missed in #10705. Could you please remove the MetaLogShim naming from the codebase in this PR?
Change-Id: I53022a20eecf194426f22615b0564bce6be004b9
Change-Id: Ie8e0da9fe54eb47cdf0a3d7e0c4b88d8a2da6067
mapan1984
force-pushed
the
fix-param-error
branch
from
2fb1fab to
e44602c
Compare
Contributor
Author
|
@chia7712 I think all the remaining |
chia7712
reviewed
Aug 15, 2025
| @@ -15,7 +15,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package org.apache.kafka.metalog; | |||
Member
There was a problem hiding this comment.
could you please remove org.apache.kafka.metalog from import-control-metadata.xml?
Contributor
Author
There was a problem hiding this comment.
Sure, have been removed.
Change-Id: Ib2cb665a8a3af3c5d7a2958dc63e74212492273b
mapan1984
changed the title
Member
|
@mapan1984 thanks for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct parameter name from
logManagertoraftClient(leftover fromPR #10705)
Reviewers: Chia-Ping Tsai chia7712@gmail.com