Skip to content

MINOR: Cleanups in jmh-benchmarks module #20374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 3 commits into from
Aug 20, 2025
+4 −31
Merged

MINOR: Cleanups in jmh-benchmarks module #20374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4ee917
Cleanups in jmh-benchmarks module
sjhajharia Aug 19, 2025
b86c67f
fix
sjhajharia Aug 20, 2025
9c9ae17
fix
sjhajharia Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...enchmarks/src/main/java/org/apache/kafka/jmh/assignor/StreamsStickyAssignorBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
import org.openjdk.jmh.annotations.Warmup;
import org.openjdk.jmh.infra.Blackhole;

import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -107,7 +106,7 @@ public void setup() {
taskAssignor = new StickyTaskAssignor();

Map<String, StreamsGroupMember> members = createMembers();
this.assignmentConfigs = Collections.singletonMap(
this.assignmentConfigs = Map.of(
"num.standby.replicas",
Integer.toString(standbyReplicas)
);
Expand Down Expand Up @@ -138,7 +137,7 @@ private void simulateIncrementalRebalance() {
for (Map.Entry<String, AssignmentMemberSpec> member : groupSpec.members().entrySet()) {
MemberAssignment memberAssignment = members.getOrDefault(
member.getKey(),
new MemberAssignment(Collections.emptyMap(), Collections.emptyMap(), Collections.emptyMap())
new MemberAssignment(Map.of(), Map.of(), Map.of())
);

updatedMemberSpec.put(member.getKey(), new AssignmentMemberSpec(
Expand Down
30 changes: 2 additions & 28 deletions jmh-benchmarks/src/main/java/org/apache/kafka/jmh/core/TestPurgatoryPerformance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import java.util.Random;
import java.util.concurrent.CountDownLatch;
Expand Down Expand Up @@ -405,12 +404,7 @@ public void shutdown() throws InterruptedException {

}

private static class Scheduled implements Delayed {
final FakeOperation operation;

public Scheduled(FakeOperation operation) {
this.operation = operation;
}
private record Scheduled(FakeOperation operation) implements Delayed {

@Override
public long getDelay(TimeUnit unit) {
Expand All @@ -429,30 +423,11 @@ else if (operation.completesAt > other.operation.completesAt)
}
}

private static class FakeOperationKey implements DelayedOperationKey {
private final String key;

public FakeOperationKey(String key) {
this.key = key;
}

private record FakeOperationKey(String key) implements DelayedOperationKey {
@Override
public String keyLabel() {
return key;
}

@Override
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
FakeOperationKey that = (FakeOperationKey) o;
return Objects.equals(key, that.key);
}

@Override
public int hashCode() {
return Objects.hash(key);
}
}

private static class FakeOperation extends DelayedOperation {
Expand All @@ -469,7 +444,6 @@ public FakeOperation(long delayMs, long latencyMs, CountDownLatch latch) {

@Override
public void onExpiration() {

}

@Override
Expand Down