Skip to content

Conversation

@shashankhs11
Copy link
Contributor

@shashankhs11 shashankhs11 commented Aug 26, 2025

Added new section for window serdes and update Streams configuration
page accordingly.

Reviewers: Matthias J. Sax matthias@confluent.io

@shashankhs11
Copy link
Contributor Author

Tagging @mjsax for review.

Also, I need help in rendering the html to preview my changes. I was able to find the guidelines to render the kafka-site repo but not the Kafka Code repo. Is there a way we can preview these changes?

@mimaison
Copy link
Member

You can run ./gradlew siteDocsTar to generate the website archive. Then to preview it, extract it in your kafka-site repository and run ./start-preview.sh

@mimaison mimaison requested a review from mjsax August 26, 2025 11:56
@shashankhs11
Copy link
Contributor Author

This is the preview of the changes in datatypes.html

docs-update-1

This is the first iteration of the changes, I think it does not look very clean, tbh, but I will work on this actively to get it completed asap.

I would really appreciate any inputs on what kind of details to include from a user's perspective for all the new details.

  • Should we include code examples?
  • Should we include details like in previous sections (setting configs)?

@mjsax mjsax removed the triage PRs from the community label Aug 27, 2025
Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a pass.

@mimaison -- I don't think we should block the next RC on this PR. Might take a little longer. We can always update kafka-site later.

@shashankhs11 shashankhs11 requested a review from mjsax August 27, 2025 23:46
@shashankhs11
Copy link
Contributor Author

<version>2.8.0</version>

Should we change the above line to

<version>{{fullDotVersion}}</version>

Is it required to be the specific version 2.8.0?

@mjsax
Copy link
Member

mjsax commented Aug 30, 2025

Yes... Seems this is incorrect for many years... and when we move off hard-coded versions to {{fullDotVersion}} we overlooked it, but nobody noticed until now...

Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. One smaller nit comment. Also great find about the version issues. Let's include this fix.

shashankhs11 and others added 2 commits August 29, 2025 17:48
Co-authored-by: Matthias J. Sax <mjsax@apache.org>
@github-actions github-actions bot removed the small Small PRs label Aug 30, 2025
@shashankhs11
Copy link
Contributor Author

made the required changes @mjsax

@shashankhs11 shashankhs11 requested a review from mjsax August 30, 2025 00:54
@mjsax
Copy link
Member

mjsax commented Sep 2, 2025

Will hold of merging until 4.1 went out, and I can cherry-pick to AK 4.1 branch, and you can do a PR against kafka-site.git to get the change live right away.

@shashankhs11
Copy link
Contributor Author

Sounds good! Thank you!

Also, I would like to suggest a minor addition to this page - Contributing Website Documentation Changes

I would like to add a step to preview changes from kafka code repository which seems to be missing. Like as mentioned here - #20408 (comment)

@shashankhs11
Copy link
Contributor Author

you can do a PR against kafka-site.git

Here is the PR apache/kafka-site#716 :)

@mimaison
Copy link
Member

mimaison commented Sep 3, 2025

Will hold of merging until 4.1 went out, and I can cherry-pick to AK 4.1 branch

Feel free to merge and backport to 4.1. I've bumped 4.1 to 4.1.1-SNAPSHOT, it's open to commits

@mjsax mjsax merged commit 639492c into apache:trunk Sep 9, 2025
22 checks passed
@mjsax
Copy link
Member

mjsax commented Sep 9, 2025

Thanks for the PR @shashankhs11. Merged to trunk and cherry-picked to 4.1 branch.

mjsax pushed a commit that referenced this pull request Sep 9, 2025
Added new section for window serdes and update Streams configuration
page accordingly.

Reviewers: Matthias J. Sax <matthias@confluent.io>
@shashankhs11 shashankhs11 deleted the KAFKA-15307 branch September 9, 2025 01:15
eduwercamacaro pushed a commit to littlehorse-enterprises/kafka that referenced this pull request Nov 12, 2025
Added new section for window serdes and update Streams configuration
page accordingly.

Reviewers: Matthias J. Sax <matthias@confluent.io>
shashankhs11 added a commit to shashankhs11/kafka that referenced this pull request Dec 15, 2025
Added new section for window serdes and update Streams configuration
page accordingly.

Reviewers: Matthias J. Sax <matthias@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants