KAFKA-19776: Fix log values for previous leader id and epoch #20671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stores the existing values for both the fields in a local variable for logging.
github-actions
bot
added
triage
OmniaGM
approved these changes
Oct 9, 2025
Contributor
OmniaGM
left a comment
OmniaGM
left a comment
There was a problem hiding this comment.
Nice catch thanks for the fix. Will wait for the pipeline to pass first.
chia7712
reviewed
Oct 9, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@gaurav-narula nice find and sorry for late review. Just one small comment from me
| s"Previous leader $prevLeaderReplicaIdOpt and previous leader epoch was $prevLeaderEpoch.") | ||
| } else { | ||
| stateChangeLogger.info(s"Skipped the become-follower state change for $topicPartition with topic id $topicId, " + | ||
| s"partition registration $partitionRegistration and isNew=$isNew since it is already a follower with leader epoch $leaderEpoch.") |
Member
There was a problem hiding this comment.
Should this leaderEpoch also be replaced by prevLeaderEpoch?
Contributor
Author
There was a problem hiding this comment.
Indeed! On a further look, it seems both the regressions were introduced with https://github.com/apache/kafka/pull/14138/files. I'll raise another PR.
gaurav-narula
added a commit
to gaurav-narula/kafka
that referenced
this pull request
Oct 9, 2025
We missed a branch in apache#20671. This PR handles the else branch where we log about skipping the follower state change. Also updated the doc for the method as it was out of date.
chia7712
pushed a commit
that referenced
this pull request
Oct 10, 2025
We missed a branch in #20671. This PR handles the else branch where we log about skipping the follower state change. Also updated the doc for the method as it was out of date. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
…20671) Stores the existing values for both the fields in a local variable for logging. Reviewers: Omnia Ibrahim <o.g.h.ibrahim@gmail.com>
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
We missed a branch in apache#20671. This PR handles the else branch where we log about skipping the follower state change. Also updated the doc for the method as it was out of date. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
shashankhs11
pushed a commit
to shashankhs11/kafka
that referenced
this pull request
Dec 15, 2025
…20671) Stores the existing values for both the fields in a local variable for logging. Reviewers: Omnia Ibrahim <o.g.h.ibrahim@gmail.com>
shashankhs11
pushed a commit
to shashankhs11/kafka
that referenced
this pull request
Dec 15, 2025
We missed a branch in apache#20671. This PR handles the else branch where we log about skipping the follower state change. Also updated the doc for the method as it was out of date. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores the existing values for both the fields in a local variable for
logging.
Reviewers: Omnia Ibrahim o.g.h.ibrahim@gmail.com