Skip to content

KAFKA-19998: KRaft client should expose the latest committed kraft version for some readers#21205

Open
kevin-wu24 wants to merge 2 commits intoapache:trunkfrom
kevin-wu24:KAFKA-19998
Open

KAFKA-19998: KRaft client should expose the latest committed kraft version for some readers#21205
kevin-wu24 wants to merge 2 commits intoapache:trunkfrom
kevin-wu24:KAFKA-19998

Conversation

@kevin-wu24
Copy link
Contributor

Readers like the SimpleApiVersionsManager and the MetadataCache should only know about the latest committed kraft version. Others, like the broker registration manager, need to know the potentially uncommitted kraft version.

@github-actions github-actions bot added triage PRs from the community core Kafka Broker kraft small Small PRs labels Dec 22, 2025
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin-wu24 thanks for this patch. one dumb question: what are the drawbacks if API Versions response uses the "uncommitted" kraft version?

@kevin-wu24
Copy link
Contributor Author

what are the drawbacks if API Versions response uses the "uncommitted" kraft version?

It's mainly a UX issue that impacts clusters undergoing a kraft version upgrade, or clusters who have not committed a "bootstrapped" kraft version 1 yet (i.e. because of network partitioning).

The issue of exposing the uncommitted kraft version in the APIVersions response is that the finalized features level for kraft may be different depending on the node to which I send APIVersionsRequest. It also is not really "finalized." Metadata version also has this issue, which is being addressed as part of: #21122

@github-actions github-actions bot removed the triage PRs from the community label Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants