MINOR: Sync up 'kafka-run-class.bat' with 'kafka-run-class.sh'#2238
Closed
vahidhashemian wants to merge 1 commit intoapache:trunkfrom
Closed
MINOR: Sync up 'kafka-run-class.bat' with 'kafka-run-class.sh'#2238vahidhashemian wants to merge 1 commit intoapache:trunkfrom
vahidhashemian wants to merge 1 commit intoapache:trunkfrom
Conversation
Some of the recent changes to `kafka-run-clas.sh` have not been applied to `kafka-run-class.bat`. Some of these recent changes include setting proper streams or connect classpaths.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
LGTM, thanks for helping to keep the windows support working well! |
soenkeliebau
pushed a commit
to soenkeliebau/kafka
that referenced
this pull request
Feb 7, 2017
Some of the recent changes to `kafka-run-class.sh` have not been applied to `kafka-run-class.bat`. These recent changes include setting proper streams or connect classpaths. So any streams or connect use case that leverages `kafka-run-class.bat` would fail with an error like ``` Error: Could not find or load main class org.apache.kafka.streams.??? ``` Author: Vahid Hashemian <vahidhashemian@us.ibm.com> Reviewers: Ewen Cheslack-Postava <ewen@confluent.io> Closes apache#2238 from vahidhashemian/minor/sync_up_kafka-run-class.bat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the recent changes to
kafka-run-class.shhave not been applied tokafka-run-class.bat.These recent changes include setting proper streams or connect classpaths. So any streams or connect use case that leverages
kafka-run-class.batwould fail with an error like