MINOR: follow-up test for create topic acl (KIP-277)#5155
MINOR: follow-up test for create topic acl (KIP-277)#5155ijuma merged 3 commits intoapache:trunkfrom
Conversation
537b9f8 to
b02a04c
Compare
Check handling of a Metadata request with a mix of existing and non-existing topics. Co-authored-by: Edoardo Comar <ecomar@uk.ibm.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
b02a04c to
96b1228
Compare
|
@ijuma I have rebased this PR a few times. would you like to merge it ? thanks |
ijuma
left a comment
There was a problem hiding this comment.
LGTM. I assume this test fails if we make the change that we had in the previous PR?
|
Hi @ijuma I thought you were going to commit to the |
|
I only merged to trunk. PRs target trunk so the benefit of backporting seems minimal. |
|
I am not sure I understand ... KIP-277 is in |
|
@ijuma ^ |
|
The testing gap existed previously though. By your logic, every time we find a testing gap, we need to backport the fix to every branch. In any case, since you seem to care a lot about this (even if the reason is unclear to me), I will cherry-pick it to 2.0 (it's harmless, but taking committer time on something with minimal benefit compared to other things). |
…isting topics (#5155) A bug in the original KIP-277 submission was caught during code review, but it was not detected by the tests. Fix that gap. Co-authored-by: Edoardo Comar <ecomar@uk.ibm.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
|
I understand that committer time is a scarce resource, but I thought the testing gap was due to the introduction of KIP-277 in 2.0. |
…isting topics (apache#5155) A bug in the original KIP-277 submission was caught during code review, but it was not detected by the tests. Fix that gap. Co-authored-by: Edoardo Comar <ecomar@uk.ibm.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
Check handling of a Metadata Request with a mix of existing and
non-existing topics.
The particular codepath was not exercised by a test in the original PR.
@ijuma fixed the code path on merge
This small testcase covers that
Co-authored-by: Edoardo Comar ecomar@uk.ibm.com
Co-authored-by: Mickael Maison mickael.maison@gmail.com
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)