Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong documentation #67

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Fix wrong documentation #67

merged 2 commits into from
Mar 21, 2023

Conversation

enjoy-binbin
Copy link
Member

@enjoy-binbin enjoy-binbin commented Mar 21, 2023

This PR also change was extreme long to is extremely long to be precise.

@enjoy-binbin
Copy link
Member Author

btw, i see this:

pexpire | √ | precision is in seconds
pexpireat | √ | precision is in seconds
pttl | √ | precision is in seconds

we says these commands precision is in seconds, is that right? i did not dive into the kvrocks source code
(redis precision is in milliseconds)

docs/supported-commands.md Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member

Hi @enjoy-binbin, thanks for your contribution first.

we says these commands precision is in seconds, is that right? i did not dive into the kvrocks source code

Yes, that's right. Currently, Kvrocks stores the expiration time in 32-bit, so it cannot support the millisecond now. Support those commands are for compatible with Redis, and @PragmaTwice is working on supporting 64-bit expiration time in this PR: apache/kvrocks#1342.

@enjoy-binbin
Copy link
Member Author

@git-hulk great, glad to hear that, thanks for the tip / infomation

Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk merged commit 4591a03 into apache:main Mar 21, 2023
@enjoy-binbin enjoy-binbin deleted the fix_wrong_doc branch March 21, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants