code review from twice, thanks a lot

apache · Aug 3, 2023 · 2ea7000 · 2ea7000
1 parent ecd0f5e
commit 2ea7000
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/types/redis_string.cc b/src/types/redis_string.cc
@@ -386,7 +386,7 @@ rocksdb::Status String::MSet(const std::vector<StringPair> &pairs, uint64_t ttl,
     batch->Put(metadata_cf_handle_, ns_key, bytes);
     std::optional<LockGuard> guard;
     if (lock) {
-      guard(storage_->GetLockManager(), ns_key);
+      guard.emplace(storage_->GetLockManager(), ns_key);
     }
     auto s = storage_->Write(storage_->DefaultWriteOptions(), batch->GetWriteBatch());
     if (!s.ok()) return s;