Rename function

src/types/bloom_filter.cc

@@ -67,7 +67,7 @@ bool BlockSplitBloomFilter::Init(std::string bitset) {
   return true;
 }
 
-std::unique_ptr<const BlockSplitBloomFilter> BlockSplitBloomFilter::CreateNonOwned(const std::string& bitset) {
+std::unique_ptr<const BlockSplitBloomFilter> BlockSplitBloomFilter::CreateReadOnlyBloomFilter(const std::string& bitset) {
   return std::unique_ptr<const BlockSplitBloomFilter>(new BlockSplitBloomFilter(bitset));
 }
 

src/types/bloom_filter.h

@@ -84,12 +84,12 @@ class BlockSplitBloomFilter {
   /// @return false if the number of bytes of Bloom filter bitset is not a power of 2, and true means successfully init
   bool Init(std::string bitset);
 
-  /// Create the non-owned BlockSplitBloomFilter. It use the bitset as underlying bitset. It is the caller's
+  /// Create the read-only BlockSplitBloomFilter. It use the caller's bitset as underlying bitset. It is the caller's
   /// responsibility to ensure the bitset would not to change.
   ///
   /// @param bitset The given bitset for the Bloom filter underlying bitset.
   /// @return the unique_ptr of the const non-owned BlockSplitBloomFilter
-  static std::unique_ptr<const BlockSplitBloomFilter> CreateNonOwned(const std::string& bitset);
+  static std::unique_ptr<const BlockSplitBloomFilter> CreateReadOnlyBloomFilter(const std::string& bitset);
 
   /// Minimum Bloom filter size, it sets to 32 bytes to fit a tiny Bloom filter.
   static constexpr uint32_t kMinimumBloomFilterBytes = 32;
@@ -173,7 +173,7 @@ class BlockSplitBloomFilter {
   static uint64_t Hash(const char* data, size_t length);
 
  private:
-  // The private constructor of BlockSplitBloomFilter. It's only used for CreateNonOwned
+  // The private constructor of BlockSplitBloomFilter. It's only used for CreateReadOnlyBloomFilter
   explicit BlockSplitBloomFilter(const std::string& bitset);
 
   // Bytes in a tiny Bloom filter block.

src/types/redis_bloom_chain.cc

@@ -113,7 +113,7 @@ void BloomChain::bloomAdd(const Slice &item, std::string *bf_data) {
 
 bool BloomChain::bloomCheck(const Slice &item, std::string &bf_data) {
   std::unique_ptr<const BlockSplitBloomFilter> block_split_bloom_filter_non_owned =
-      BlockSplitBloomFilter::CreateNonOwned(bf_data);
+      BlockSplitBloomFilter::CreateReadOnlyBloomFilter(bf_data);
 
   uint64_t h = BlockSplitBloomFilter::Hash(item.data(), item.size());
   return block_split_bloom_filter_non_owned->FindHash(h);