resolve comment

apache · Sep 17, 2022 · cfd338f · cfd338f
1 parent e188819
commit cfd338f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/redis_cmd.cc b/src/redis_cmd.cc
@@ -4182,17 +4182,12 @@ class CommandHello final : public Commander {
         auto authResult = AuthenticateUser(conn, svr->GetConfig(), user_password);
         switch (authResult) {
         case AuthResult::INVALID_PASSWORD:
-          *output = Redis::Error("ERR invalid password");
-          break;
+          return Status(Status::NotOK, "invalid password");
         case AuthResult::NO_REQUIRE_PASS:
-          *output = Redis::Error("ERR Client sent AUTH, but no password is set");
-          break;
+          return Status(Status::NotOK, "Client sent AUTH, but no password is set");
         case AuthResult::OK:
           break;
         }
-        if (authResult != AuthResult::OK) {
-          return Status::OK();
-        }
         next_arg += 1;
       } else if (opt == "SETNAME" && moreargs != 0) {
         const std::string& name = args_[next_arg + 1];

diff --git a/src/redis_connection.cc b/src/redis_connection.cc
@@ -450,4 +450,4 @@ void Connection::ResetMultiExec() {
   DisableFlag(Connection::kMultiExec);
 }
 
-} // namespace Redis
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -450,4 +450,4 @@ void Connection::ResetMultiExec() { @@
       DisableFlag(Connection::kMultiExec);
     }
-    } // namespace Redis
+    }