Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deleting old logs by day #1168

Closed
1 of 2 tasks
git-hulk opened this issue Dec 7, 2022 · 2 comments · Fixed by #1171
Closed
1 of 2 tasks

Support deleting old logs by day #1168

git-hulk opened this issue Dec 7, 2022 · 2 comments · Fixed by #1171
Assignees
@IoCing
Labels
enhancement type enhancement feature type new feature good first issue Good for newcomers help wanted Good for newcomers

Comments

@git-hulk
Copy link
Member

git-hulk commented Dec 7, 2022 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

Currently, Kvrocks didn't have a way to auto-delete old logs which may occupy the disk capacity, so it'd be better to offer a way to keep recent logs only.

related discussion: #1167

Solution

We can do it by simply adding a configuration to enable or disable it since the glog has already supported removing old logs.

https://github.com/google/glog/blob/c18db3903b9f0abd80ae740fde94f7e32aa40b92/README.rst#automatically-remove-old-logs

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@git-hulk git-hulk added enhancement type enhancement help wanted Good for newcomers good first issue Good for newcomers feature type new feature labels Dec 7, 2022
@IoCing
Copy link
Contributor

IoCing commented Dec 8, 2022

I would like to work on it !

@git-hulk
Copy link
Member Author

git-hulk commented Dec 8, 2022

Thanks @IoCing, assigned

@IoCing IoCing mentioned this issue Dec 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IoCing IoCing

Labels
enhancement type enhancement feature type new feature good first issue Good for newcomers help wanted Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add config for log cleaner IoCing/incubator-kvrocks
2 participants
@git-hulk @IoCing