feat: add config for log cleaner #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torwig
reviewed
Dec 8, 2022
PragmaTwice
reviewed
Dec 8, 2022
PragmaTwice
reviewed
Dec 8, 2022
caipengbo
reviewed
Dec 9, 2022
caipengbo
reviewed
Dec 9, 2022
git-hulk
reviewed
Dec 9, 2022
git-hulk
reviewed
Dec 9, 2022
|
General looks good to me, except for two suggestions. |
Co-authored-by: hulk <hulk.website@gmail.com>
Co-authored-by: hulk <hulk.website@gmail.com>
thanks |
|
@IoCing Would you mind adding Go test cases for this configuration, to make sure it can be changed in-flight? |
tisonkun
reviewed
Dec 9, 2022
tisonkun
approved these changes
Dec 21, 2022
|
It seems Travis CI takes a longer time to finish. Perhaps we should restore the GitHub Actions + QEMU solution XD. Merging... |
|
@IoCing Thank you! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1168.