Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specify release candidate number in x.py package source #1407

Closed
1 of 2 tasks
tisonkun opened this issue Apr 29, 2023 · 4 comments · Fixed by #1419
Closed
1 of 2 tasks

Support specify release candidate number in x.py package source #1407

tisonkun opened this issue Apr 29, 2023 · 4 comments · Fixed by #1419
Assignees
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers

Comments

@tisonkun
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

Otherwise, the RC always has the same tag name as the formal release name. And it's awkward to force-push for overwriting refs.

Solution

cc @PragmaTwice @git-hulk may you check where we should use -rcX during the release process?

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@tisonkun tisonkun added enhancement type enhancement help wanted Good for newcomers good first issue Good for newcomers labels Apr 29, 2023
@PragmaTwice
Copy link
Member

Sure, we can make it push to a tag with rc suffix.

@tisonkun
Copy link
Member Author

@PragmaTwice what I'm afraid of is that there is still other place we need rc suffix except the git tag :D

@ZENOTME
Copy link
Contributor

ZENOTME commented Apr 29, 2023

I can help with this.

Not sure whether my understand is correct, it's to support
./x.py package source -v 2.3.2 -rc 1 and then create a tag '2.3.2-rc1'.

@tisonkun
Copy link
Member Author

tisonkun commented May 5, 2023

@ZENOTME Thanks for your input! That sounds good to me. Please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants