Support specify release candidate number #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapleFU
reviewed
May 5, 2023
|
@mapleFU Thanks for reminding! Have fixed it. |
mapleFU
reviewed
May 5, 2023
x.py
Outdated
| @@ -216,16 +216,18 @@ def write_version(release_version: str) -> str: | |||
| return version | |||
|
|
|||
|
|
|||
| def package_source(release_version: str) -> None: | |||
| def package_source(release_version: str, release_candidate_number: int) -> None: | |||
There was a problem hiding this comment.
Should it be an optional ( https://docs.python.org/3/library/typing.html#typing.Optional ) ?
mapleFU
reviewed
May 5, 2023
x.py
Outdated
| if release_candidate_number == None: | ||
| run(git, 'tag', '-a', f'v{version}', '-m', f'[source-release] copy for tag v{version}') | ||
| else: | ||
| run(git, 'tag', '-a', f'v{version}-rc{release_candidate_number}', '-m', f'[source-release] copy for tag v{version}') |
There was a problem hiding this comment.
f'[source-release] copy for tag v{version}-rc{release_candidate_number}'
?
|
Rest LGTM |
mapleFU
previously approved these changes
May 5, 2023
PragmaTwice
previously approved these changes
May 5, 2023
tisonkun
reviewed
May 5, 2023
tisonkun
approved these changes
May 5, 2023
|
The release manual should be updated later also - https://github.com/apache/incubator-kvrocks-website/blob/f2ecdd3743fbbeddbbe293ced5fd49d6d74a0626/community/create-a-release.md?plain=1#L173 |
|
Thanks @ZENOTME , merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1407
it's to support specify like
./x.py package source -v 2.3.2 -rc 1and then create a tag '2.3.2-rc1'.