Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing redis_mode field in INFO command #1926

Closed
1 of 2 tasks
mnizhq007 opened this issue Dec 8, 2023 · 0 comments · Fixed by #1927
Closed
1 of 2 tasks

Missing redis_mode field in INFO command #1926

mnizhq007 opened this issue Dec 8, 2023 · 0 comments · Fixed by #1927
Assignees
Labels
bug type bug

Comments

@mnizhq007
Copy link

mnizhq007 commented Dec 8, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Version

kvrocks:2.5.1
redis-cli:4.0

Minimal reproduce step

The Redis manager tool can't recognize the Kvrocks when enabling the cluster mode. And I found is may be caused by missing redis_mode field in Kvrocks's info command.

在使用开源工具redis manger时,发现无法识别kvrocks集群,排查日志,显示为redis mode返回值为kong
2af0bce70f1ebb38d9de002b117c7c0
14b6b8150535367b91cfea933680bee

What did you expect to see?

Kvrocks's INFO command should return redis_mode to make the Redis manager happy.

登录kvrocks执行INFO SERVER后,redis mode会返回对应信息。

What did you see instead?

登录kvrocks,执行INFO SERVER
a53689e824ec091dd81ac5447a48a93
没有返回该字段,而Redis会返回
fa29fb0a83d78b14ee8cbb8be690c7c

Anything Else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@mnizhq007 mnizhq007 added the bug type bug label Dec 8, 2023
@enjoy-binbin enjoy-binbin self-assigned this Dec 8, 2023
enjoy-binbin added a commit to enjoy-binbin/kvrocks that referenced this issue Dec 8, 2023
Although we will already show cluster_enabled in INFO CLUSTER,
some tools such as redis manger will need this field to determine
whether it is cluster mode.

If cluster mode is enabled, redis_mode is displayed as cluster,
otherwise it is standalone.

Fixes apache#1926.
@git-hulk git-hulk changed the title INFO SERVER执行,没有返回redis_mode的字段信息 Missing redis_mode field in INFO command Dec 8, 2023
git-hulk pushed a commit that referenced this issue Dec 8, 2023
Although we will already show cluster_enabled in INFO CLUSTER,
some tools such as Redis Manager will need this field to determine
whether it is cluster mode.

If cluster mode is enabled, redis_mode is displayed as a cluster,
otherwise, it is standalone. We also use this opportunity to add
a kvrocks_mode field.

Fixes #1926.
git-hulk pushed a commit that referenced this issue Dec 8, 2023
Although we will already show cluster_enabled in INFO CLUSTER,
some tools such as Redis Manager will need this field to determine
whether it is cluster mode.

If cluster mode is enabled, redis_mode is displayed as a cluster,
otherwise, it is standalone. We also use this opportunity to add
a kvrocks_mode field.

Fixes #1926.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug type bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants