bug: inappropriate type of ttl_ of CommandSet

[J0HN50N133]

Search before asking

• I had searched in the issues and found no similar issues.

Version

Since db2860d until now.

Minimal reproduce step

kvrocks/src/commands/cmd_string.cc

Line 307 in a238053

if (ttl_ < 0) {

Here determine whether ttl_ less than 0, if so, doing deletion. However, the type of ttl_ if uint64_t which is impossible to less than 0.

kvrocks/src/commands/cmd_string.cc

Line 340 in a238053

uint64_t ttl_ = 0;

What did you expect to see?

If ttl_ less than 0, doing deletion.

What did you see instead?

The condition will never be true, thus, deletion will never be done.

Anything Else?

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[git-hulk]

@J0HN50N133 Thanks for your report.

You're right, would you submit a PR to fix this?

[J0HN50N133]

I could fix it. Although the behaviour here is correct (because of implicit cast), it's disturbing.