Refactor TTL processing in string type #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
approved these changes
Apr 14, 2024
|
mapleFU
reviewed
Apr 14, 2024
| @@ -107,8 +103,7 @@ class CommandGetEx : public Commander { | |||
| } | |||
|
|
|||
| private: | |||
| uint64_t ttl_ = 0; | |||
| bool persist_ = false; | |||
| std::optional<uint64_t> expire_; | |||
There was a problem hiding this comment.
Would we have a class wrapper to distinguish the syntax?
There was a problem hiding this comment.
I think a interface with something like has_ttl() would look better, but feel free to just merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we use TTL as a parameter in string operations, and it's not good since we should use an absolute value in internal implementations to avoid double casting (
EXAT timestamp-> cast to TTL -> cast back to expire timestamp, these introduce twoGetTimestampMS()with probably different result).Here we change TTL to timestamp as the parameter of string operations.
Close #2248.