Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slot migrate not support json type #2583

Closed
1 of 2 tasks
Genuineh opened this issue Oct 6, 2024 · 5 comments · Fixed by #2654
Closed
1 of 2 tasks

slot migrate not support json type #2583

Genuineh opened this issue Oct 6, 2024 · 5 comments · Fixed by #2654
Assignees
Labels
bug type bug

Comments

@Genuineh
Copy link

Genuineh commented Oct 6, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Version

v2.9.0

Minimal reproduce step

1、start slot migrate with json type data

What did you expect to see?

slot migrate work well on json data type

What did you see instead?

not working

Anything Else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@Genuineh Genuineh added the bug type bug label Oct 6, 2024
@git-hulk git-hulk self-assigned this Oct 8, 2024
@git-hulk
Copy link
Member

git-hulk commented Oct 8, 2024

@Genuineh will support this at the next release.

@Genuineh
Copy link
Author

Genuineh commented Oct 8, 2024

Thanks, #2580 seems can be completed together and when is the next release version expected to be launched? @git-hulk

@PragmaTwice
Copy link
Member

PragmaTwice commented Oct 8, 2024

For slot migration, maybe you can try to set migrate-type to raw-key-value to make it work on any datatype.

migrate-type redis-command

Although for kvrocks2redis we still need to do the supporting work.

@Genuineh
Copy link
Author

Genuineh commented Oct 9, 2024

@PragmaTwice @git-hulk Thanks, slot migration work well on raw-key-value mode. By the way, the company I am in has a strong intention to use a database with a kv structure based on rocksdb to replace databases such as mongodb to store a large amount of business data. However, formal businesses often have various analysis or other needs, and these needs are usually handled by some specialized databases. At present, kvrocks may only temporarily provide migration to redis, which is not very friendly for those with such business needs. The current structure has a not-low learning cost for expansion. If the community needs to do a large amount of adaptation for different databases, it is a huge project. If a standard scheme that users can quickly expand can be provided, these tasks don't need to be done and users' different needs can be met. For a simple scheme, for example, it can directly connect to raw-key-value. Users only need to rewrite a writer and a checker.

@git-hulk
Copy link
Member

git-hulk commented Oct 9, 2024

@Genuineh I got your point. It would be great to add a layer to separate the change event and from the target writer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug type bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants