Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test has wrong sleep time #873

Closed
tisonkun opened this issue Sep 13, 2022 · 0 comments · Fixed by #919
Closed

Unit test has wrong sleep time #873

tisonkun opened this issue Sep 13, 2022 · 0 comments · Fixed by #919
Assignees
Labels
bug type bug

Comments

@tisonkun
Copy link
Member

https://github.com/apache/incubator-kvrocks/blob/unstable/tests/cppunit/rwlock_test.cc#L170

This unit test sleep time is NOT right, expected 100ms but current is 1ms. I think 1ms is too short to guarantee the else condition thread will be always be scheduled before the if condition. I'll bring this sleep time fix in the next PR.

Originally posted by @git-hulk in #870 (comment)

@tisonkun tisonkun added the bug type bug label Sep 13, 2022
@git-hulk git-hulk self-assigned this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug type bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants