Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix many typos in cluster.cc #919

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Fix many typos in cluster.cc #919

merged 3 commits into from
Sep 26, 2022

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Sep 25, 2022

  1. Fix typos in the cluster.cc
  2. Use const string when appearing many times
  3. Fix incorrect sleep time in rwlock test case

Close #873

caipengbo
caipengbo previously approved these changes Sep 26, 2022
caipengbo
caipengbo previously approved these changes Sep 26, 2022
@caipengbo caipengbo changed the title Fix many typo in cluster.cc Fix many typos in cluster.cc Sep 26, 2022
@PragmaTwice
Copy link
Member

I notice that CI is down in darwin clang. Maybe #include <chrono> is needed to use namespace std::chrono_literals.

@git-hulk
Copy link
Member Author

I notice that CI is down in darwin clang. Maybe #include <chrono> is needed to use namespace std::chrono_literals.

Yes, should include <chrono>, fixed.

@git-hulk
Copy link
Member Author

hi @PragmaTwice, seems the namespace of chrono_literals is a bit different between compilers, do you suggest rollbacking to use the previous way?

@PragmaTwice
Copy link
Member

hi @PragmaTwice, seems the namespace of chrono_literals is a bit different between compilers, do you suggest rollbacking to use the previous way?

Sure. Maybe it need c++14 🤣

@git-hulk
Copy link
Member Author

git-hulk commented Sep 26, 2022

hi @PragmaTwice, seems the namespace of chrono_literals is a bit different between compilers, do you suggest rollbacking to use the previous way?

Sure. Maybe it need c++14 🤣

I was a bit confuse when looking its docs, it says std::literals::chrono_literals required at least C++14, but std::chrono_literals can be found in C++11's chrono. Let's use the legacy way first.

@git-hulk
Copy link
Member Author

Thanks all, merging...

@git-hulk git-hulk merged commit 9b6cc11 into unstable Sep 26, 2022
@git-hulk git-hulk deleted the fix/typos branch September 27, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test has wrong sleep time
3 participants