Update C++ standard to 17 #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
requested review from
git-hulk,
torwig,
ShooterIT,
tisonkun and
caipengbo
|
I compiled successfully on Macos! Thank you very much for your contribution.❤️ |
torwig
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
@PragmaTwice Thank you for the description and explanation in the related discussion thread.
git-hulk
approved these changes
Oct 18, 2022
caipengbo
approved these changes
Oct 18, 2022
|
Can I upgrade rocksdb to 7.x at the same time? |
@xiaobiaozhao I think we can wait and see because |
|
Thanks all. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check #970 for details