-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TCL test unit/tls to Go case #1012
Conversation
cmd *exec.Cmd | ||
|
||
addr *net.TCPAddr | ||
tlsAddr *net.TCPAddr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A TLS-enabled server has both a non-TLS port and a TLS port which can work at the same time, so I think we need two fields here.
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I push a few commits and notice that TLS tests may work on darwin now (work for me locally, I suspect it's about TLS server name). Turn on to verify.
Emmm...Unfortunately it doesn't. Reverting... |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@PragmaTwice @git-hulk I don't know why it keeps failing...Cannot reproduce locally and should not be related to this patch (although I try to "fix" it, it fails continuously). |
Yes, not related to current PR, I'm wondering if it's caused by Go parallel run tests. |
@git-hulk No. Golang only runs tests in parallel if you write |
Signed-off-by: tison <wander4096@gmail.com>
@vmihailenco do you have any ideas here? This test is our last test to be migrated with go-redis XD |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
It seems that the bitmap failure does related to this patch. I'm digging into the test scripts. See identical CI runs: https://github.com/apache/incubator-kvrocks/actions/runs/3287762862/jobs/5417324374 |
Perhaps try |
@vmihailenco Let me try it if this run still fails. It's strange since it happens only for darwin platform. |
Co-authored-by: Twice <twice.mliu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending for merging...
After I add back |
It closes #995.