Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mailing list to README #1023

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Oct 21, 2022

Since dev@ is already overwhelmed with discussion messages, and I always get duplicated discussion notification mails from both github and dev@), I thought I could move the discussion notifications to issues@ as well.

I also removed the google group link because it has not been used for a long time and many developers canot get notifications. Is this appropriate? @git-hulk

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One comment inline.

README.md Outdated Show resolved Hide resolved
Co-authored-by: tison <wander4096@gmail.com>
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun
Copy link
Member

tisonkun commented Oct 21, 2022

@PragmaTwice we can have a path filter for skipping CI on docs change.

But since we required the status, it can be a bit tricky and we should make use of https://github.com/dorny/paths-filter to skip steps.

It's not a requirement of this patch, of course.

@PragmaTwice
Copy link
Member Author

@PragmaTwice we can have a path filter for skipping CI on docs change.

But since we required the status, it can be a bit tricky and we should make use of https://github.com/dorny/paths-filter to skip steps.

It's not a requirement of this patch, of course.

Sure, we need to skip CI if no actual code changes.

@PragmaTwice PragmaTwice merged commit ca54a5c into apache:unstable Oct 21, 2022
@tisonkun
Copy link
Member

Let me create an issue for it.

manchurio pushed a commit to manchurio/kvrocks that referenced this pull request Oct 21, 2022
* Add mailing list to README

* Update .asf.yaml

* Update README.md

Co-authored-by: tison <wander4096@gmail.com>

Co-authored-by: tison <wander4096@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants