Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CAS and CAD return statuses #1055

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Fix CAS and CAD return statuses #1055

merged 2 commits into from
Oct 31, 2022

Conversation

torwig
Copy link
Contributor

@torwig torwig commented Oct 30, 2022

No description provided.

git-hulk
git-hulk approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @torwig

tisonkun
tisonkun approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although, it seems that the method comment is incorrect also. Would you go through this method?

//  1 if the operation is successful
//  -1 if the user_key does not exist
//  0 if the operation fails

@ShooterIT ShooterIT requested a review from caipengbo October 31, 2022 08:09
@tisonkun
Copy link
Member

Merging...

Further improvement can be done later. They're not blockers.

@tisonkun tisonkun merged commit 0a1a9fc into apache:unstable Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@tisonkun tisonkun tisonkun approved these changes

@caipengbo caipengbo caipengbo approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@torwig @tisonkun @git-hulk @caipengbo @PragmaTwice