[BugFix] Fixing logging initialized before loaded #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
previously approved these changes
Nov 1, 2022
PragmaTwice
previously approved these changes
Nov 2, 2022
torwig
force-pushed
the
bug-fix/fixing-log-initialized-before-init
branch
from
166db4d to
79634dc
Compare
|
@git-hulk @PragmaTwice No idea why CI failed... |
@mapleFU Yes, we found a frequently crash test case and it is no related to current PR even it would also block the merge. @PragmaTwice has uploaded the coredump file to artifacts in PR, still investigating the reason now. |
git-hulk
approved these changes
Nov 4, 2022
|
Thanks @mapleFU, merging.. |
2 tasks
xiaobiaozhao
pushed a commit
to xiaobiaozhao/kvrocks
that referenced
this pull request
Nov 4, 2022
PragmaTwice
pushed a commit
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1059
May same as #1060
When
Config::Loadis called,callbackis called when setting fields, so it will callLOG(INFO) << ..., which would initialize logger.Config::Loadis called before initialize loggers, so logger is initialized and not follow theConfig's behavior.And here we found that, when program is loading,
srvis nullptr. So we can check it ahead of logging