`HrangebyLex` supports specify intervals #1120

tanruixiang · 2022-11-13T17:10:47Z

This close #1118 and #1082 .

src/commands/redis_cmd.cc

src/types/redis_hash.h

tisonkun · 2022-11-26T09:04:03Z

Code conflict as we did some refactors. cc @torwig @PragmaTwice could you help with providing the plan on following refactors so that we don't resolve conflicts many times?

tanruixiang · 2022-11-26T09:06:43Z

I will try to finish this pr as soon as possible before the big refactoring.

git-hulk

Cool, LGTM

src/commands/redis_cmd.cc

…incubator-kvrocks into support_more_hrange_opitons

src/commands/redis_cmd.cc

src/types/redis_hash.h

src/types/redis_hash.cc

…incubator-kvrocks into support_more_hrange_opitons

ShooterIT

zrangebylex also has lex range parser, we should unite the two into one.

ShooterIT · 2022-12-13T05:40:27Z

src/commands/redis_cmd.cc

-      return {Status::RedisParseErr, errWrongNumOfArguments};
+    CommandParser parser(args, 4);
+    while (parser.Good()) {
+      if (parser.EatEqICase("REV")) {


why support REV option?

This can be aligned with zrange and makes sense, for example if you need to take the largest data.

About aligning zrange I will deal with it in the new pr.

i think hrangebylex is enough currently since i heard there is such a demand. Developers may not be used to that hash support range operations, we can implement when someone wants it, WDYT?

PragmaTwice · 2022-12-13T09:17:20Z

src/types/redis_hash.cc

@@ -355,4 +383,36 @@ rocksdb::Status Hash::Scan(const Slice &user_key, const std::string &cursor, uin
  return SubKeyScanner::Scan(kRedisHash, user_key, cursor, limit, field_prefix, fields, values);
 }

+Status Hash::ParseRangeLexSpec(const std::string &min, const std::string &max, HashRangeSpec *spec) {


We can merge these same structure and methods of HashRangeSpec and ZRangeSpec in next PR.

why not this pr, i don't think we should import different function to deal with similar things

I have no strong opinion for this. Could you merge these structures and functions in this PR? @tanruixiang

I have no strong opinion for this. Could you merge these structures and functions in this PR? @tanruixiang

Ok. Sorry to have missed this comment.

PragmaTwice · 2023-01-13T07:36:49Z

src/types/redis_hash.cc

@@ -355,4 +383,36 @@ rocksdb::Status Hash::Scan(const Slice &user_key, const std::string &cursor, uin
  return SubKeyScanner::Scan(kRedisHash, user_key, cursor, limit, field_prefix, fields, values);
 }

+Status Hash::ParseRangeLexSpec(const std::string &min, const std::string &max, CommonRangeLexSpec *spec) {


Could you move the function to range_spec.cc, so it can be reused in zset and hash?

OK, I am very sorry for missing this function.

PragmaTwice · 2023-01-13T12:56:52Z

src/common/range_spce.cc

@@ -0,0 +1,53 @@
+/*


there is a typo in the filename :)

src/common/range_spce.cc

src/common/range_spec.h

PragmaTwice

LGTM. cc @git-hulk @ShooterIT

ShooterIT

Thanks for your impressive work @tanruixiang

PragmaTwice · 2023-01-17T03:42:07Z

Thanks all. Merging...

Support more hrange options

4044c05

tanruixiang linked an issue Nov 13, 2022 that may be closed by this pull request

Doubt about the HRANGE command #1082

Closed

2 tasks

tanruixiang changed the title ~~Support more HRANGE options~~ Support more HRANGE options Nov 13, 2022

tanruixiang requested review from PragmaTwice, torwig, ShooterIT and git-hulk November 13, 2022 17:13

tanruixiang added 2 commits November 14, 2022 13:44

Merge branch 'unstable' into support_more_hrange_opitons

cd7f46d

Merge branch 'unstable' into support_more_hrange_opitons

1c9e289

git-hulk reviewed Nov 15, 2022

View reviewed changes

src/commands/redis_cmd.cc Outdated Show resolved Hide resolved

torwig reviewed Nov 15, 2022

View reviewed changes

src/types/redis_hash.h Outdated Show resolved Hide resolved

tanruixiang added 2 commits December 2, 2022 17:07

Merge branch 'unstable' into support_more_hrange_opitons

7be715e

rename hrange

ee9a2fe

git-hulk previously approved these changes Dec 4, 2022

View reviewed changes

”fix“

4be2812

tanruixiang dismissed git-hulk’s stale review via 4be2812 December 4, 2022 07:45

Merge branch 'unstable' into support_more_hrange_opitons

5d743ea

tanruixiang changed the title ~~Support more HRANGE options~~ HrangebyLex supports specify intervals Dec 4, 2022

torwig reviewed Dec 4, 2022

View reviewed changes

src/commands/redis_cmd.cc Outdated Show resolved Hide resolved

tanruixiang added 2 commits December 4, 2022 16:27

remove redundant variables

3566014

Merge branch 'support_more_hrange_opitons' of github.com:tanruixiang/…

f51b6d7

…incubator-kvrocks into support_more_hrange_opitons

PragmaTwice reviewed Dec 4, 2022

View reviewed changes

src/commands/redis_cmd.cc Outdated Show resolved Hide resolved

tanruixiang and others added 3 commits December 6, 2022 16:21

fix typo

a2a48d9

Merge branch 'unstable' into support_more_hrange_opitons

3cf648e

Merge branch 'unstable' into support_more_hrange_opitons

d47b335

PragmaTwice reviewed Dec 6, 2022

View reviewed changes

src/commands/redis_cmd.cc Outdated Show resolved Hide resolved

PragmaTwice reviewed Dec 6, 2022

View reviewed changes

src/types/redis_hash.h Outdated Show resolved Hide resolved

PragmaTwice reviewed Dec 6, 2022

View reviewed changes

src/types/redis_hash.cc Outdated Show resolved Hide resolved

tanruixiang and others added 4 commits December 10, 2022 22:53

fix code style

4b4ac09

Merge branch 'support_more_hrange_opitons' of github.com:tanruixiang/…

4c6fb4b

…incubator-kvrocks into support_more_hrange_opitons

Merge branch 'unstable' into support_more_hrange_opitons

bfd774d

Merge branch 'unstable' into support_more_hrange_opitons

6dc81ad

ShooterIT reviewed Dec 13, 2022

View reviewed changes

PragmaTwice previously approved these changes Dec 13, 2022

View reviewed changes

PragmaTwice reviewed Dec 13, 2022

View reviewed changes

tanruixiang added 2 commits January 9, 2023 00:35

Merge branch 'unstable' into support_more_hrange_opitons

b027d43

use common lex range struct

850a1c8

tanruixiang dismissed PragmaTwice’s stale review via 850a1c8 January 11, 2023 11:07

tanruixiang added 2 commits January 11, 2023 19:10

add lisence

3fe6c40

format

8b8485d

tanruixiang requested a review from PragmaTwice January 12, 2023 05:42

PragmaTwice reviewed Jan 13, 2023

View reviewed changes

tanruixiang added 2 commits January 13, 2023 17:12

move ParseRangeLexSpec

a2f53a8

Merge branch 'unstable' into support_more_hrange_opitons

5073fad

PragmaTwice reviewed Jan 13, 2023

View reviewed changes

tanruixiang added 2 commits January 14, 2023 01:56

rename

427f816

add empty line

581597d

PragmaTwice requested review from ShooterIT and git-hulk and removed request for git-hulk January 14, 2023 03:23

PragmaTwice approved these changes Jan 14, 2023

View reviewed changes

git-hulk approved these changes Jan 16, 2023

View reviewed changes

ShooterIT approved these changes Jan 16, 2023

View reviewed changes

PragmaTwice added 2 commits January 17, 2023 10:27

Merge branch 'unstable' into support_more_hrange_opitons

644298b

Merge branch 'unstable' into support_more_hrange_opitons

37bc82b

PragmaTwice merged commit 003d8fb into apache:unstable Jan 17, 2023

PragmaTwice mentioned this pull request Jan 17, 2023

Add hrangebylex to supported commands apache/kvrocks-website#37

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`HrangebyLex` supports specify intervals #1120

`HrangebyLex` supports specify intervals #1120

tanruixiang commented Nov 13, 2022

tisonkun commented Nov 26, 2022

tanruixiang commented Nov 26, 2022

git-hulk left a comment

ShooterIT left a comment

ShooterIT Dec 13, 2022

tanruixiang Dec 13, 2022

tanruixiang Dec 13, 2022

ShooterIT Dec 16, 2022

PragmaTwice Dec 13, 2022 •

edited

Loading

ShooterIT Dec 16, 2022 •

edited

Loading

PragmaTwice Dec 16, 2022

tanruixiang Dec 19, 2022 •

edited

Loading

PragmaTwice Jan 13, 2023

tanruixiang Jan 13, 2023

PragmaTwice Jan 13, 2023 •

edited

Loading

PragmaTwice left a comment

ShooterIT left a comment

PragmaTwice commented Jan 17, 2023

HrangebyLex supports specify intervals #1120

HrangebyLex supports specify intervals #1120

Conversation

tanruixiang commented Nov 13, 2022

tisonkun commented Nov 26, 2022

tanruixiang commented Nov 26, 2022

git-hulk left a comment

Choose a reason for hiding this comment

ShooterIT left a comment

Choose a reason for hiding this comment

ShooterIT Dec 13, 2022

Choose a reason for hiding this comment

tanruixiang Dec 13, 2022

Choose a reason for hiding this comment

tanruixiang Dec 13, 2022

Choose a reason for hiding this comment

ShooterIT Dec 16, 2022

Choose a reason for hiding this comment

PragmaTwice Dec 13, 2022 • edited Loading

Choose a reason for hiding this comment

ShooterIT Dec 16, 2022 • edited Loading

Choose a reason for hiding this comment

PragmaTwice Dec 16, 2022

Choose a reason for hiding this comment

tanruixiang Dec 19, 2022 • edited Loading

Choose a reason for hiding this comment

PragmaTwice Jan 13, 2023

Choose a reason for hiding this comment

tanruixiang Jan 13, 2023

Choose a reason for hiding this comment

PragmaTwice Jan 13, 2023 • edited Loading

Choose a reason for hiding this comment

PragmaTwice left a comment

Choose a reason for hiding this comment

ShooterIT left a comment

Choose a reason for hiding this comment

PragmaTwice commented Jan 17, 2023

`HrangebyLex` supports specify intervals #1120

`HrangebyLex` supports specify intervals #1120

PragmaTwice Dec 13, 2022 •

edited

Loading

ShooterIT Dec 16, 2022 •

edited

Loading

tanruixiang Dec 19, 2022 •

edited

Loading

PragmaTwice Jan 13, 2023 •

edited

Loading