Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modernize-avoid-bind warning reported by clang-tidy #1121

Merged
merged 7 commits into from
Nov 14, 2022
Merged

Fix modernize-avoid-bind warning reported by clang-tidy #1121

merged 7 commits into from
Nov 14, 2022

Conversation

Phoeniwx
Copy link
Contributor

@Phoeniwx Phoeniwx commented Nov 14, 2022 •
edited by tanruixiang
Loading

This close #1094

@tanruixiang tanruixiang changed the title Fix: #1094 modernize-avoid-bind warning Fix modernize-avoid-bind warning reported by clang-tidy Nov 14, 2022
tanruixiang
tanruixiang reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@tanruixiang tanruixiang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. It looks like there is some original code that forgot to remove. By the way, you need to add the check to .clang-tidy and resolve conflicts. And use ./x.py format to format code.

src/commands/redis_cmd.cc Outdated Show resolved Hide resolved
src/commands/redis_cmd.cc Outdated Show resolved Hide resolved
src/cluster/cluster.cc Outdated Show resolved Hide resolved
torwig
torwig reviewed Nov 14, 2022
View reviewed changes
src/cluster/cluster.cc Outdated Show resolved Hide resolved
src/commands/redis_cmd.cc Outdated Show resolved Hide resolved
src/commands/redis_cmd.cc Outdated Show resolved Hide resolved
@Phoeniwx
Copy link
Contributor Author

Sorry guys, I ve removed old commented code, renamed variables, formatted code and updated .clang-tidy

PragmaTwice
PragmaTwice reviewed Nov 14, 2022
View reviewed changes
.clang-tidy Outdated Show resolved Hide resolved
@Phoeniwx @PragmaTwice
Update .clang-tidy
e22cc4d 
Co-authored-by: Twice <twice@apache.org>
@PragmaTwice
Copy link
Member

Thanks for your contribution!

@PragmaTwice PragmaTwice merged commit 52cbfd4 into apache:unstable Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanruixiang tanruixiang tanruixiang left review comments

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@torwig torwig torwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix modernize-avoid-bind warning reported by clang-tidy
4 participants
@Phoeniwx @PragmaTwice @torwig @tanruixiang