Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the script load should return SHA as the bulk string #1133

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Fix the script load should return SHA as the bulk string #1133

merged 1 commit into from
Nov 23, 2022

Conversation

git-hulk
Copy link
Member

This closes #1132

@git-hulk git-hulk mentioned this pull request Nov 23, 2022
Closed
2 tasks
tisonkun
tisonkun approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Compatibility is really hard 🤣

@tisonkun tisonkun merged commit 6f2def2 into apache:unstable Nov 23, 2022
@git-hulk
Copy link
Member Author

git-hulk commented Nov 24, 2022 •
edited
Loading

LGTM. Compatibility is really hard 🤣

Yes, Tcl and Go redis client parse the simple string correctly, so we can't find this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

@ShooterIT ShooterIT Awaiting requested review from ShooterIT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lua script load return bool true (PHP client)
2 participants
@git-hulk @tisonkun