Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve files structure #1134

Merged
merged 1 commit into from
Nov 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
2 changes: 1 addition & 1 deletion .github/workflows/kvrocks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
sudo apt install -y clang-format-12 clang-tidy-12
- uses: apache/skywalking-eyes/header@v0.4.0
with:
config: tools/ci/licenserc.yml
config: .github/config/licenserc.yml
- name: Check with clang-format
id: check-format
run: ./x.py check format --clang-format-path clang-format-12
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ add_executable(kvrocks src/main.cc)
target_link_libraries(kvrocks PRIVATE kvrocks_objs ${EXTERNAL_LIBS})

# kvrocks2redis sync tool
file(GLOB KVROCKS2REDIS_SRCS tools/kvrocks2redis/*.cc)
file(GLOB KVROCKS2REDIS_SRCS utils/kvrocks2redis/*.cc)
add_executable(kvrocks2redis ${KVROCKS2REDIS_SRCS})

target_link_libraries(kvrocks2redis PRIVATE kvrocks_objs ${EXTERNAL_LIBS})
Expand Down
20 changes: 0 additions & 20 deletions tools/kvrocks2redis/tests/README.md

This file was deleted.

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
20 changes: 20 additions & 0 deletions utils/kvrocks2redis/tests/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
## Populate data and append new data script

For testing the `kvrocks2redis` utility, manually check generate AOF.

## Usage

* Start `kvrocks` and `kvrocks2redis`
* [ ] TODO automatic create docker env
* Install dependency::
* pip install git+https://github.com/andymccurdy/redis-py.git@2.10.3
* Usage:

```bash
# populate data
python populate-kvrocks.py
# check generated aof file
# append new data
python append-data-to-kvrocks.py
# check appended new aof data
```
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions x.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@ def get_source_files() -> List[str]:
*glob("src/**/*.cc", recursive=True),
*glob("tests/cppunit/**/*.h", recursive=True),
*glob("tests/cppunit/**/*.cc", recursive=True),
*glob("tools/kvrocks2redis/**/*.h", recursive=True),
*glob("tools/kvrocks2redis/**/*.cc", recursive=True),
*glob("utils/kvrocks2redis/**/*.h", recursive=True),
*glob("utils/kvrocks2redis/**/*.cc", recursive=True),
]


Expand Down