Split util.h to more concrete util headers
#1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caipengbo
approved these changes
Nov 26, 2022
git-hulk
approved these changes
Nov 26, 2022
|
Thanks all. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #973 (comment), it seems a header file named
util.hcan lead to a disaster: all functions that we do not know where to put will be placed in this file, making this file cluttered and bloated.We need more specific file names rather than
util.h, so in this PR, we separate functions inutil.hinto different files:string_util.h,io_util.h,time_util.handthread_util.h.