refactor: move VERSION to src/folder #1148

[CNLHC]

This fixes #1148.

[CNLHC]

x.py is only invoked from the project root so using relative dir in x.py seems to be ok.

[tisonkun]

I'd prefer to write VERSION.txt instead of .VERSION. There's no reason for the VERSION file to be hidden.

@PragmaTwice for #1148 (comment), I'd say that version.h.in is not a typical source file also, but we host all source files and meta source files (that generates source files under src). You can think of proto definitions.

[CNLHC]

I'd prefer to write VERSION.txt instead of .VERSION. There's no reason for the VERSION file to be hidden.

@PragmaTwice for #1148 (comment), I'd say that version.h.in is not a typical source file also, but we host all source files and meta source files (that generates source files under src). You can think of proto definitions.

I agree with @tisonkun that the VERSION should be placed in the src because this file does influence the output binary and can be regarded as some kind of source file.

[tisonkun]

@PragmaTwice Another approach is that we thoroughly remove the VERSION file but pass the version by CMake option and default to 999.999.999 :)

[PragmaTwice]

@PragmaTwice Another approach is that we thoroughly remove the VERSION file but pass the version by CMake option and default to 999.999.999 :)

It seems hard to do so in a source distribution, while users are required to specify a version number to build.

[tisonkun]

It seems hard to do so in a source distribution, while users are required to specify a version number to build.

Yep..

[tisonkun]

Thanks for your contribution! Merging...