Add the compatible Redis version to the info command #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add redis_version add kvrocks_version
git-hulk
reviewed
Dec 4, 2022
git-hulk
changed the title
git-hulk
previously approved these changes
Dec 4, 2022
PragmaTwice
reviewed
Dec 4, 2022
PragmaTwice
reviewed
Dec 4, 2022
xiaobiaozhao
force-pushed
the
change-redis-version-config
branch
from
07bab2d to
85cbe0c
Compare
git-hulk
approved these changes
Dec 5, 2022
|
@PragmaTwice @ShooterIT Does it look good to you? |
PragmaTwice
approved these changes
Dec 6, 2022
|
Thanks all, merging... |
tisonkun
reviewed
Dec 7, 2022
| @@ -44,6 +44,7 @@ | |||
| #include "worker.h" | |||
|
|
|||
| std::atomic<int> Server::unix_time_ = {0}; | |||
| constexpr const char *REDIS_VERSION = "4.0.0"; | |||
There was a problem hiding this comment.
Out of curiosity, does it mean that we're functionality compatible with Redis 4.x?
There was a problem hiding this comment.
But we support STREAM delivered in Redis 5.
There was a problem hiding this comment.
Yes, we are roughly aligning the protocol with the Redis 4.x, but the data type and command can be newer than 4.x.
There was a problem hiding this comment.
I also think in the future there will be some commands that only kvrocks has but redis doesn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add redis_version into the info command
this closes #1157