Inplace construct error message in StatusOr while data type is large enough #1198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use
std::unique_ptr<std::string>
inStatusOr<T>
to represent the error message (in the union type:T
or error message), in order to make the error message as small as possible. Hence the size ofStatusOr<int>
will be equal to2 * sizeof(void*)
rather thansizeof(void*) + sizeof(std::string)
, wheresizeof(std::string)
is32
in libstdc++ (so basically16
vs40
).But if
sizeof(T)
is large thansizeof(std::string)
by itself, it is unnecessary to construct the error message on heap for a more compact stack size (since it will never be more compact). Thus we can construct the error message in StatusOr in-place while data type is large enough (i.e.sizeof(T)
>=sizeof(std::string)
).