Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlock when unblocking connection on stream #1228

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Fix deadlock when unblocking connection on stream #1228

merged 1 commit into from
Jan 17, 2023

Conversation

torwig
Copy link
Contributor

@torwig torwig commented Jan 16, 2023

I forgot to advance the iterator.
Which leads to an infinite loop. That eventually stops the execution of all writable commands.

Thanks to @aleksraiden for catching (and experiencing) this bug.

@aleksraiden
Copy link
Contributor

Thanks, @torwig

Now all works fine!

@PragmaTwice
Copy link
Member

Thanks all. Merging...

@PragmaTwice PragmaTwice merged commit 319e841 into apache:unstable Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@torwig @aleksraiden @PragmaTwice @git-hulk