Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XREAD returns dedicated status if it blocks #1232

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

torwig
Copy link
Contributor

@torwig torwig commented Jan 24, 2023

In order to be consistent with such blocking commands like BLPOP and BRPOP.

In order to be consistent with such blocking commands like BLPOP and BRPOP
Copy link
Member

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, I wonder if there could be some test cases to identify this change (if it is not hard to add).

@torwig
Copy link
Contributor Author

torwig commented Jan 25, 2023

@PragmaTwice No because it worked correctly even without this change :)
In this case, the loop wasn't stopped on s.Is<Status::BlockingCmd>() clause. But, according to the code, the actual reply wasn't sent because the reply variable remained empty.

Copy link
Member

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.

@torwig
Copy link
Contributor Author

torwig commented Jan 25, 2023

Merging...

@torwig torwig merged commit d032f29 into apache:unstable Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants