Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LuaJIT to improve the performance of scripts #1241

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Enable LuaJIT to improve the performance of scripts #1241

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0de0678
feat: def use luajit
xiaobiaozhao Feb 2, 2023
4dbaa62
ci: update ci
xiaobiaozhao Feb 2, 2023
507e8d6
docs: update readme for luajit
xiaobiaozhao Feb 2, 2023
f1a881d
ci: rename with_luajit to without_luajit
xiaobiaozhao Feb 2, 2023
fc0b026
Update README.md
git-hulk Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/kvrocks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,22 +131,22 @@ jobs:
without_jemalloc: -DDISABLE_JEMALLOC=ON
with_openssl: -DENABLE_OPENSSL=ON
compiler: gcc
- name: Ubuntu GCC with luaJIT
- name: Ubuntu GCC without luaJIT
os: ubuntu-20.04
with_openssl: -DENABLE_OPENSSL=ON
with_luajit: -DUSE_LUAJIT=ON
with_luajit: -DUSE_LUAJIT=OFF
compiler: gcc
- name: Ubuntu GCC ASan with luaJIT
- name: Ubuntu GCC ASan without luaJIT
os: ubuntu-20.04
without_jemalloc: -DDISABLE_JEMALLOC=ON
with_luajit: -DUSE_LUAJIT=ON
with_luajit: -DUSE_LUAJIT=OFF
with_sanitizer: -DENABLE_ASAN=ON
with_openssl: -DENABLE_OPENSSL=ON
compiler: gcc
- name: Ubuntu GCC TSan with luaJIT
- name: Ubuntu GCC TSan without luaJIT
os: ubuntu-20.04
without_jemalloc: -DDISABLE_JEMALLOC=ON
with_luajit: -DUSE_LUAJIT=ON
with_luajit: -DUSE_LUAJIT=OFF
with_sanitizer: -DENABLE_TSAN=ON
with_openssl: -DENABLE_OPENSSL=ON
compiler: gcc
Expand Down Expand Up @@ -196,7 +196,7 @@ jobs:
run: |
./x.py build -j$NPROC --unittest --compiler ${{ matrix.compiler }} ${{ matrix.without_jemalloc }} ${{ matrix.with_luajit }} \
${{ matrix.with_ninja }} ${{ matrix.with_sanitizer }} ${{ matrix.with_openssl }} ${{ env.CMAKE_EXTRA_DEFS }}

- name: Setup Coredump
if: ${{ startsWith(matrix.os, 'ubuntu') }}
run: |
Expand Down Expand Up @@ -225,7 +225,7 @@ jobs:
GOCASE_RUN_ARGS="-tlsEnable"
fi
./x.py test go build $GOCASE_RUN_ARGS

- name: Find reports and crashes
if: always()
run: |
Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ option(ENABLE_ASAN "enable address santinizer" OFF)
option(ENABLE_TSAN "enable thread santinizer" OFF)
option(ASAN_WITH_LSAN "enable leak santinizer while address santinizer is enabled" ON)
option(ENABLE_STATIC_LIBSTDCXX "link kvrocks with static library of libstd++ instead of shared library" ON)
option(USE_LUAJIT "use luaJIT instead of lua" OFF)
option(USE_LUAJIT "use luaJIT instead of lua" ON)
option(ENABLE_OPENSSL "enable openssl to support tls connection" OFF)
option(ENABLE_IPO "enable interprocedural optimization" ON)
option(ENABLE_UNWIND "enable libunwind in glog" ON)
Expand All @@ -48,7 +48,7 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
message(FATAL_ERROR "It is expected to build kvrocks with Xcode toolchains 10 or above")
endif()
else()
message(WARNING "The compiler you are currently using is not officially supported,
message(WARNING "The compiler you are currently using is not officially supported,
so you can try switching to GCC>=7 or Clang>=5 if you encounter problems")
endif()

Expand Down