Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically build and push the docker image when tagging a new version #1247

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Automatically build and push the docker image when tagging a new version #1247

merged 2 commits into from
Feb 6, 2023

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Feb 6, 2023

This closes #1246

@git-hulk @PragmaTwice
Update .github/workflows/release.yaml
342fb29 
Co-authored-by: Twice <twice@apache.org>
@git-hulk git-hulk marked this pull request as ready for review February 6, 2023 03:17
@git-hulk
Copy link
Member Author

git-hulk commented Feb 6, 2023

Thanks all, merging...

@caipengbo Can help to push a new tag to have a try, the DOCKER_USERNAME and DOCKER_PASSWORD had existed before if my memory serves.

@git-hulk git-hulk merged commit fb4aa54 into apache:unstable Feb 6, 2023
tisonkun
tisonkun reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow can break Apache release process that any official release should go through a vote process.

What if any commit push a new tag and "release" a docker image that doesn't associate with a vote?

@tisonkun
Copy link
Member

tisonkun commented Feb 6, 2023

This is already discussed at:

@git-hulk
Copy link
Member Author

git-hulk commented Feb 6, 2023

OK, let's reverse this change and do them manually.

git-hulk added a commit that referenced this pull request Feb 6, 2023
@git-hulk
Revert "Automatically build and push the docker image when tagging a …
7fffb07 
…new version (#1247)"

This reverts commit fb4aa54.
@git-hulk git-hulk mentioned this pull request Feb 6, 2023
Merged
git-hulk added a commit that referenced this pull request Feb 6, 2023
@git-hulk
Revert "Automatically build and push the docker image when tagging a …
2e151fb 
…new version (#1247)" (#1248)

This reverts commit fb4aa54.
@tisonkun tisonkun mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@caipengbo caipengbo caipengbo approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@ShooterIT ShooterIT Awaiting requested review from ShooterIT

@torwig torwig Awaiting requested review from torwig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the release CI to build and publish the docker image
4 participants
@git-hulk @tisonkun @caipengbo @PragmaTwice