Show version and commit hash in a more pretty way #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
approved these changes
Feb 8, 2023
torwig
approved these changes
Feb 8, 2023
|
Thanks all. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I adjust the format of the version (and commit hash) printing, e.g.
Before:
kvrocks version 999.999.999 @1234567After:
kvrocks unstable (commit 1234567)Before:
kvrocks version 2.3.0 @1234567After:
kvrocks version 2.3.0 (commit 1234567)(no commit hash, e.g. in an archive)
Before:
kvrocks version 2.3.0 @After:
kvrocks version 2.3.0(no commit hash, e.g. in an archive)
Before:
kvrocks version 999.999.999 @After:
kvrocks unstable(an additional WARNING will be printed while executing CMake, while it is on the unstable branch and a commit hash cannot be retrieved)