-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use append action instead of nargs for cmake defs in x.py #1256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. May I ask the disk_stats
related changes? We'd better avoid mixing changes, or at least describe what it is.
Previously, all ASan and TSan checks in CI have never been applied (only the last |
Thanks for your explanation! That's reasonable. |
Thanks all. Merging... |
Currently, we use
nargs=*
for parsing-D
arguments, e.g.-D X=1 Y=2
->["X=1", "Y=2"]
,-D X=1 -D Y=2
->["Y=2"]
.We need to change it to
action=append
to align the behavior with CMake, e.g.-D X=1 -D Y=2
->["X=1", "Y=2"]
.It solved #1254 and fix all wrong argument parsing in GitHub Actions.