Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use append action instead of nargs for cmake defs in x.py #1256

Merged
merged 52 commits into from
Feb 19, 2023

Conversation

PragmaTwice
Copy link
Member

Currently, we use nargs=* for parsing -D arguments, e.g. -D X=1 Y=2 -> ["X=1", "Y=2"], -D X=1 -D Y=2 -> ["Y=2"].

We need to change it to action=append to align the behavior with CMake, e.g. -D X=1 -D Y=2 -> ["X=1", "Y=2"].

It solved #1254 and fix all wrong argument parsing in GitHub Actions.

git-hulk
git-hulk previously approved these changes Feb 10, 2023
tisonkun
tisonkun previously approved these changes Feb 10, 2023
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May I ask the disk_stats related changes? We'd better avoid mixing changes, or at least describe what it is.

@PragmaTwice
Copy link
Member Author

LGTM. May I ask the disk_stats related changes? We'd better avoid mixing changes, or at least describe what it is.

Previously, all ASan and TSan checks in CI have never been applied (only the last -D was kept, all other cmake defs were ignored), so I try to solve all ASan and TSan reports to make the CI pass.

@tisonkun
Copy link
Member

Thanks for your explanation! That's reasonable.

@PragmaTwice
Copy link
Member Author

Thanks all. Merging...

@PragmaTwice PragmaTwice merged commit 62d9113 into apache:unstable Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants