Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for execution timing of commands from lua #1297

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Fix for execution timing of commands from lua #1297

merged 1 commit into from
Mar 6, 2023

Conversation

DenizPiri
Copy link
Contributor

Before this, the timing of the commands executed by lua scripts wasn't accounted for correctly. This should resolve that issue.

@DenizPiri
Fix for execution timing of commands from lua
71001cb 
Before this, the timing of the commands executed by lua scripts wasn't accounted for correctly. This should resolve that issue.
tisonkun
tisonkun approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally looks correct. +1 for merging.

It would be better if you can add a test (e.g. a new go case).

git-hulk
git-hulk approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk
Copy link
Member

git-hulk commented Mar 6, 2023 •
edited
Loading

Thanks all, merging...

@git-hulk git-hulk merged commit d913b42 into apache:unstable Mar 6, 2023
@git-hulk
Copy link
Member

git-hulk commented Mar 6, 2023

@DenizPiri Thanks for your good catch and contribution again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@tisonkun tisonkun tisonkun approved these changes

@xiaobiaozhao xiaobiaozhao Awaiting requested review from xiaobiaozhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DenizPiri @git-hulk @tisonkun