Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor task runner for more robust runtime state #1318

Merged
merged 5 commits into from
Mar 13, 2023
Merged

Refactor task runner for more robust runtime state #1318

merged 5 commits into from
Mar 13, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Mar 13, 2023 •
edited
Loading

  • use notify_one
  • return status instead of void
  • remove useless unlock

@PragmaTwice PragmaTwice requested review from git-hulk and torwig March 13, 2023 08:35
torwig
torwig approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PragmaTwice PragmaTwice merged commit cb7ae54 into apache:unstable Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @torwig