Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Status to avoid large stack size in happy path #1330

Closed
wants to merge 5 commits into from

Conversation

PragmaTwice
Copy link
Member

Follow the implementation of Status in RocksDB, google absl, doris and more, we refactor the Status to make it just a pointer (8 instead of 40 for libstdc++ std::string).

For happy path (OK status) with large probability, it benefits the performance.

@PragmaTwice PragmaTwice requested review from git-hulk and torwig March 18, 2023 07:36
torwig
torwig previously approved these changes Mar 18, 2023
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Good job, @PragmaTwice!

tisonkun
tisonkun previously approved these changes Mar 19, 2023
@tisonkun
Copy link
Member

There are still ICE:

lto1: internal compiler error: in add_symbol_to_partition_1, at lto/lto-partition.c:153
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-9/README.Bugs> for instructions.
lto-wrapper: fatal error: /usr/bin/g++ returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status

@PragmaTwice
Copy link
Member Author

There are still ICE:

lto1: internal compiler error: in add_symbol_to_partition_1, at lto/lto-partition.c:153
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-9/README.Bugs> for instructions.
lto-wrapper: fatal error: /usr/bin/g++ returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status

sad

@PragmaTwice PragmaTwice dismissed stale reviews from tisonkun and torwig via 35c626a March 19, 2023 08:53
@PragmaTwice
Copy link
Member Author

Will split this PR to multiple ones against ICE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants