Fix missing stream increment batch in cluster migration #1345
Conversation
git-hulk
requested review from
torwig,
PragmaTwice and
ShooterIT
and removed request for
torwig
|
@torwig I'm not quite familiar with the XSETID command, so I didn't handle it now. |
|
@git-hulk Thanks for your work. |
|
@torwig Thank you. So for the XSETID command, I should parse the last_added_id / entries_added / max_deleted_id, then translate it into the XSETID. Is it right? |
|
BTW, do we implement #577 (comment)? |
|
@ShooterIT Yes, it's finished but missed the WAL's increment sync. |
|
@git-hulk Yes, absolutely. |
migration Currently, the cluster slot migration will split into two stages: send snapshots and sync WAL if the snapshot was sent. For the stream, we only parsed the KVs from snapshot and missing the WAL part.
Co-authored-by: Twice <twice@apache.org>
|
Thanks all, merging.. |
There is an warning in the code: ``` /incubator-kvrocks/src/storage/batch_extractor.cc:89:50: warning: enum constant in boolean context [-Wint-in-bool-context] 89 | StreamMetadata stream_metadata(kRedisStream); ``` This was introduced in apache#1345
There is a warning in the code: ``` /incubator-kvrocks/src/storage/batch_extractor.cc:89:50: warning: enum constant in boolean context [-Wint-in-bool-context] 89 | StreamMetadata stream_metadata(kRedisStream); ``` This was introduced in #1345
Currently, the cluster slot migration will split into two stages: send snapshots and sync WAL if the snapshot was sent. For the stream, we only parsed the KVs from the snapshot and missed the WAL part.