Add SUBSTR command as redis #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the SUBSTR command, command syntax is exactly the same as GETRANGE. Although SUBSTR is already deprecated (It can be replaced by GETRANGE), we still want to support it. Note that go-redis does not support the SUBSTR command, so rdb.Do is used in go tests to test it.
|
i am new to kvrocks / c++ / go, so I pick a simple task to do first. |
|
Thanks for @enjoy-binbin contribution. I think it makes sense to support it for compatibility reasons, and it also doesn't introduce any complexity to the project. |
git-hulk
approved these changes
Mar 23, 2023
torwig
approved these changes
Mar 23, 2023
|
Thanks for your contribution! Merging... |
enjoy-binbin
added a commit
to enjoy-binbin/kvrocks-website
that referenced
this pull request
Mar 25, 2023
SUBSTR was added in apache/kvrocks#1347
PragmaTwice
pushed a commit
to apache/kvrocks-website
that referenced
this pull request
Mar 25, 2023
SUBSTR was added in apache/kvrocks#1347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the SUBSTR command, command syntax is exactly
the same as GETRANGE. Although SUBSTR is already deprecated
(It can be replaced by GETRANGE), we still want to support it.
Note that go-redis does not support the SUBSTR command, so rdb.Do
is used in go tests to test it.